This repository was archived by the owner on Dec 18, 2023. It is now read-only.
Improve screen rotation management #56
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to keep track of fragment instances after screen rotation, the "fragTags" attribute is introduced. This array contain 3 String objects representing the tags of the tab fragments. Thus, fragment updates are made using tags instead of references. Moreover, this commit fixes the 'WindowLeaked' error which is thrown when a screen rotation occurres during the display of the first run dialog window. The fix involves the new WelcomeDialogFrament class whose aim is to handle dialog instead of the StationListActivity. Indeed DialogFragment behavior is told to be more appropriate by this guide : https://developer.android.com/guide/topics/ui/dialogs. Despite this trick, the AlertDialog.Builder is copied as is.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This pull request should fix the issue #55, please let me know if you have any questions.
Regards.