Alpine building and vips working, but lost some build steps#1130
Alpine building and vips working, but lost some build steps#1130HuwSy wants to merge 2 commits intobpatrik:masterfrom
Conversation
| PI_DOCKER=true | ||
|
|
||
| EXPOSE 80 | ||
| ARG TARGETARCH |
There was a problem hiding this comment.
why did you remove this part? this is for hardware acceleration
There was a problem hiding this comment.
I did wonder what this was for and in trying to get changes I understood it came out and ran without, added back now
|
Thanks you! I made some comments. I could not really test is just yet if it actually works. |
|
It seems that it prevents build on arm/v7: I'm not sure if that is an issue. I think we can just drop it. |
I have reverted the npm install to see if it makes any difference, doubt they will but to keep the change smaller as i cant test on anything non amd64 atm. |
Possible fix for #1122 @bpatrik but I have mistakenly dropped some parts of the old build that maybe I shouldn't have. But it does at least build and render thumbs here under alpine.