Fix biased random sort by using Fisher-Yates shuffle#1131
Merged
bpatrik merged 1 commit intobpatrik:masterfrom Feb 8, 2026
Merged
Fix biased random sort by using Fisher-Yates shuffle#1131bpatrik merged 1 commit intobpatrik:masterfrom
bpatrik merged 1 commit intobpatrik:masterfrom
Conversation
The previous random sorting used a random comparator with Array.sort(), which is a well-known antipattern that produces biased results. Items tend to stay near their original (alphabetically sorted) position, causing media with similar filenames to cluster together rather than being uniformly shuffled. Replace with Fisher-Yates shuffle for both media and directories, which guarantees a uniform random permutation. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Owner
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Array.sort()with a random comparator, which is a well-known antipattern that produces biased results — items tend to stay near their original (alphabetically sorted) positionFrance - beach,France - city,Italy - beach,Italy - city), as the alphabetical pre-sort clusters them and the biased shuffle preserves those clustersTest plan
🤖 Generated with Claude Code