Skip to content

Conversation

bpg
Copy link
Owner

@bpg bpg commented Aug 10, 2025

Contributor's Note

  • I have added / updated documentation in /docs for any user-facing features or additions.
  • I have added / updated acceptance tests in /fwprovider/tests for any new or updated resources / data sources.
  • I have ran make example to verify that the change works as expected.

Proof of Work

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #0000 | Relates #0000

Summary by CodeRabbit

  • Chores
    • Removed all sample data sources and related outputs for various Proxmox SDN zone types (EVPN, QinQ, Simple, VLAN, VXLAN) and zone listings from the configuration examples. End-users will no longer see these example queries or outputs in the provided Terraform configurations.

Copy link

coderabbitai bot commented Aug 10, 2025

📝 Walkthrough

Walkthrough

This change removes all Terraform data source configurations and associated outputs for various Proxmox SDN zone types, including EVPN, QinQ, Simple, VLAN, VXLAN, and aggregate SDN zones. Each affected file previously defined a data source block and an output block to expose SDN zone attributes.

Changes

Cohort / File(s) Change Summary
EVPN SDN Zone Data Source Removal
proxmox_virtual_environment_sdn_zone_evpn/data-source.tf
Removed the entire data source and output for the proxmox_virtual_environment_sdn_zone_evpn example, which previously exposed EVPN SDN zone attributes.
QinQ SDN Zone Data Source Removal
proxmox_virtual_environment_sdn_zone_qinq/data-source.tf
Removed the data source and output for the proxmox_virtual_environment_sdn_zone_qinq example, which previously exposed QinQ SDN zone attributes.
Simple SDN Zone Data Source Removal
proxmox_virtual_environment_sdn_zone_simple/data-source.tf
Deleted the data source and output for the proxmox_virtual_environment_sdn_zone_simple example, which previously exposed Simple SDN zone attributes.
VLAN SDN Zone Data Source Removal
proxmox_virtual_environment_sdn_zone_vlan/data-source.tf
Removed the data source and output for the proxmox_virtual_environment_sdn_zone_vlan example, which previously exposed VLAN SDN zone attributes.
VXLAN SDN Zone Data Source Removal
proxmox_virtual_environment_sdn_zone_vxlan/data-source.tf
Deleted the data source and output for the proxmox_virtual_environment_sdn_zone_vxlan example, which previously exposed VXLAN SDN zone attributes.
Aggregate SDN Zones Data Sources Removal
proxmox_virtual_environment_sdn_zones/data-source.tf
Removed all data sources and outputs for listing and filtering SDN zones, including unfiltered, EVPN-only, and Simple-only queries, and their associated outputs.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Note

🔌 MCP (Model Context Protocol) integration is now available in Early Access!

Pro users can now connect to remote MCP servers under the Integrations page to get reviews and chat conversations that understand additional development context.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5151dcc and 6e579da.

📒 Files selected for processing (6)
  • proxmox_virtual_environment_sdn_zone_evpn/data-source.tf (0 hunks)
  • proxmox_virtual_environment_sdn_zone_qinq/data-source.tf (0 hunks)
  • proxmox_virtual_environment_sdn_zone_simple/data-source.tf (0 hunks)
  • proxmox_virtual_environment_sdn_zone_vlan/data-source.tf (0 hunks)
  • proxmox_virtual_environment_sdn_zone_vxlan/data-source.tf (0 hunks)
  • proxmox_virtual_environment_sdn_zones/data-source.tf (0 hunks)
💤 Files with no reviewable changes (6)
  • proxmox_virtual_environment_sdn_zone_simple/data-source.tf
  • proxmox_virtual_environment_sdn_zone_vxlan/data-source.tf
  • proxmox_virtual_environment_sdn_zone_vlan/data-source.tf
  • proxmox_virtual_environment_sdn_zone_evpn/data-source.tf
  • proxmox_virtual_environment_sdn_zone_qinq/data-source.tf
  • proxmox_virtual_environment_sdn_zones/data-source.tf

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@bpg bpg merged commit 91e0fbf into main Aug 10, 2025
8 checks passed
@bpg bpg deleted the docs-cleanup branch August 10, 2025 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant