WIP: add content types images, rootdir

[KiaraGrouwstra]

Contributor's Note

• I have added / updated documentation in /docs for any user-facing features or additions.
• I have added / updated acceptance tests in /fwprovider/tests for any new or updated resources / data sources.
• I have ran make example to verify that the change works as expected.

Proof of Work

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #0000 | Relates #0000

[gemini-code-assist]

Summary of Changes

Hello @KiaraGrouwstra, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request expands the 'proxmox_virtual_environment_file' resource by introducing support for 'images' and 'rootdir' content types. This enhancement allows users to manage a broader range of file types within their Proxmox datastores using the Terraform provider, improving its utility and alignment with Proxmox's native capabilities.

Highlights

• New Content Types: Added support for 'images' and 'rootdir' content types within the 'proxmox_virtual_environment_file' resource, expanding the types of files that can be managed.
• Documentation Updates: Updated user guides and resource documentation to reflect the newly supported 'images' and 'rootdir' content types, ensuring clarity for users.
• Validator Enhancement: Modified the Go validator for content types to include 'images' and 'rootdir', ensuring proper validation within the provider's codebase.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces support for images and rootdir content types. The changes are a good starting point, updating validators and documentation. However, as this is a work in progress, there are several areas that need to be completed. The documentation for the new types in docs/resources/virtual_environment_file.md is incomplete, with allowed file extensions marked as unknown. The content type inference logic in proxmoxtf/resource/file.go should be updated to recognize file extensions for these new types. The upload mechanism, which currently defaults to SFTP for images and rootdir, should be verified to be correct. Finally, acceptance tests for the new content types are missing and should be added to validate the implementation.

[gemini-code-assist]

The documentation for the rootdir content type is incomplete. Please clarify what file types are expected, or if it's not applicable to files, explain the purpose of this content type within the context of this resource.