Conversation
zambrovski
added
Prio: MUST
zambrovski
requested review from
emaarco and
i-am-not-giving-my-name-to-a-machine
| import org.springframework.boot.context.properties.EnableConfigurationProperties | ||
| import org.springframework.context.annotation.Bean | ||
| import org.springframework.context.annotation.Conditional | ||
| import org.springframework.stereotype.Component |
| commandExecutor = commandExecutor, | ||
|
|
||
| ) | ||
| ) |
| } | ||
| keep | ||
| } | ||
| .map { (lockedTask, activeSubscription) -> createTaskActionHandlerCallable(lockedTask, activeSubscription!!) } |
There was a problem hiding this comment.
!! signifies for me still a kind of danger, that a NullPointer could be thrown, even if this is prevented due to the filter above. however, we could remove the !! by rewriting the filter with a mapNotNull from the beginning
val taskActionHandlerCallables = lockedTasks
.asSequence()
.mapNotNull { lockedTask ->
val subscription = subscriptions.firstOrNull { it.matches(lockedTask) }
if (subscription != null) {
lockedTask to subscription
} else {
metrics.incrementDroppedTasksCounter(lockedTask.topicName!!, NO_MATCHING_SUBSCRIPTIONS)
null
}
}
.map { (lockedTask, activeSubscription) -> createTaskActionHandlerCallable(lockedTask, activeSubscription) }
i-am-not-giving-my-name-to-a-machine
left a comment
i-am-not-giving-my-name-to-a-machine
left a comment
There was a problem hiding this comment.
Lgtm. However, a lot of formatting has changed and the reason for that is unclear to me.
| } | ||
|
|
||
| internal fun deliverNewTasks() { | ||
| val subscriptions = subscriptionRepository.getTaskSubscriptions().filter { s -> s.taskType==TaskType.EXTERNAL } |
There was a problem hiding this comment.
| val subscriptions = subscriptionRepository.getTaskSubscriptions().filter { s -> s.taskType==TaskType.EXTERNAL } | |
| val subscriptions = subscriptionRepository.getTaskSubscriptions().filter { s -> s.taskType == TaskType.EXTERNAL } |
Found a bunch of weirdly formatted comparisons all across this merge request. Is this this project's formatter setting? If so, I need to update mine.
| fun ProcessInstanceWithVariablesDto.toProcessInformation() = ProcessInformation( | ||
| instanceId = this.id!!, | ||
| meta = mapOf( | ||
| meta = metaOf( |
There was a problem hiding this comment.
Should I create an MR to copy this over to the remote code? I remember adding it only for TaskInformation, not for ProcessInformation. Does that exist in remote too?
4 participants
Uh oh!
There was an error while loading. Please reload this page.