Skip to content

Conversation

barmac
Copy link
Member

@barmac barmac commented Sep 15, 2025

Proposed Changes

image

This PR undoes the breaking change in peerdeps, and brings back correct default value for cancelRemainingInstances.

Use together with camunda/camunda-bpmn-js-behaviors#109 and bpmn-io/bpmn-moddle#132.

fix: use default value for cancelRemainingInstances for edit marker

fix: undo breaking change in peer dependencies

Related to #1149

Checklist

To ensure you provided everything we need to look at your PR:

  • Brief textual description of the changes present
  • Visual demo attached
  • Steps to try out present, i.e. using the @bpmn-io/sr tool
  • Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}

@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Sep 15, 2025
@barmac barmac force-pushed the cancel-remaining-instances branch from 4b6e2fb to 46430ab Compare September 17, 2025 07:36
@barmac barmac marked this pull request as ready for review September 17, 2025 07:36
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Sep 17, 2025
@barmac barmac requested review from a team, philippfromme and jarekdanielak and removed request for a team September 17, 2025 07:37
Copy link
Member

@nikku nikku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple enough, works as expected.

I'm going to merge + release this.

@nikku nikku merged commit eedd980 into main Sep 18, 2025
9 checks passed
@nikku nikku deleted the cancel-remaining-instances branch September 18, 2025 09:40
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Sep 18, 2025
@nikku
Copy link
Member

nikku commented Sep 18, 2025

Released as v5.42.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants