Skip to content

feat: allow to replace between variants of typed events#2282

Merged
barmac merged 1 commit intodevelopfrom
replace-between-types-of-events
Feb 18, 2025
Merged

feat: allow to replace between variants of typed events#2282
barmac merged 1 commit intodevelopfrom
replace-between-types-of-events

Conversation

@barmac
Copy link
Member

@barmac barmac commented Feb 17, 2025

Related to camunda/camunda-modeler#4523

Proposed Changes

This allows to replace between start/intermediate catch/intermediate throw/end event of the same type (where allowed in BPMN).

Screen.Recording.2025-02-17.at.16.52.26.mov

Checklist

To ensure you provided everything we need to look at your PR:

  • Brief textual description of the changes present
  • Visual demo attached
  • Steps to try out present, i.e. using the @bpmn-io/sr tool
  • Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}

@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Feb 17, 2025
@barmac barmac requested review from a team, abdul99ahad and philippfromme and removed request for a team February 17, 2025 15:55
Copy link
Member

@nikku nikku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works like a charm:

capture dKAf3c_optimized

Kinda unexpected that we don't handle the choice via BpmnRules, but seems to be the usual thing in the replace options.

@barmac
Copy link
Member Author

barmac commented Feb 18, 2025

Kinda unexpected that we don't handle the choice via BpmnRules, but seems to be the usual thing in the replace options.

I agree. Implementing this would be a bigger refactoring though.

@barmac barmac merged commit 0a7c5f3 into develop Feb 18, 2025
11 checks passed
@barmac barmac deleted the replace-between-types-of-events branch February 18, 2025 10:19
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants