fix(modeling): correct sequence flow layout from corner boundary events#2395
Closed
JhaSourav07 wants to merge 0 commit intobpmn-io:developfrom
Closed
fix(modeling): correct sequence flow layout from corner boundary events#2395JhaSourav07 wants to merge 0 commit intobpmn-io:developfrom
JhaSourav07 wants to merge 0 commit intobpmn-io:developfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes sequence flow Manhattan layout when connecting from a corner-attached boundary event to a target element that is strictly axis-aligned (directly above/below or left/right), avoiding an unnecessary detour waypoint (issue #2270).
Changes:
- Enhance
getBoundaryEventTargetLayoutto detect strictly vertical vs strictly horizontal target orientation and return'v'/'h'accordingly. - Preserve existing corner-attachment routing logic for diagonal (corner-to-corner/quadrant) target orientations.
Comments suppressed due to low confidence (1)
lib/features/modeling/BpmnLayouter.js:494
- The new
verticalTargetOrientation/horizontalTargetOrientationvalues are computed once, but the later comparisons still callgetVerticalOrientation(targetOrientation)/getHorizontalOrientation(targetOrientation)again. Consider reusing the already computed values (and similarly caching the attach orientations) to avoid duplicated parsing and keep the logic easier to follow.
var verticalTargetOrientation = getVerticalOrientation(targetOrientation),
horizontalTargetOrientation = getHorizontalOrientation(targetOrientation);
// If the target is strictly above/below (no horizontal orientation)
if (verticalTargetOrientation && !horizontalTargetOrientation) {
return 'v';
}
// If the target is strictly left/right (no vertical orientation)
if (horizontalTargetOrientation && !verticalTargetOrientation) {
return 'h';
}
if (isHorizontal) {
if (isSame(getVerticalOrientation(attachOrientation), getVerticalOrientation(targetOrientation))) {
return 'h';
} else {
return 'v';
}
} else {
if (isSame(getHorizontalOrientation(attachOrientation), getHorizontalOrientation(targetOrientation))) {
return 'v';
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fbb23b0 to
a3b8df8
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
eab4f03 to
87a4516
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the Bug Fixed
This PR fixes an issue where sequence flows starting from a corner boundary event and connecting to an element directly on the same axis (e.g., placed completely below or to the side) would generate an awkward, looping layout with an unnecessary extra waypoint.
What changed
Updated
getBoundaryEventTargetLayoutinBpmnLayouter.jsto explicitly check if a target element is strictly on the same vertical or horizontal axis relative to the boundary event. When it is, the layouter now correctly returns'v'or'h', allowing the Manhattan layout engine to draw a clean, straight line instead of detouring out to the side.Steps to verify:
Fixes #2270
Before

After

Checklist:
npm run allbuild passes (executes tests + linting)Checklist
Ensure you provide everything we need to review your contribution:
Closes {LINK_TO_ISSUE}orRelated to {LINK_TO_ISSUE}@bpmn-io/srtool