feat: activate direct editing for new activities and events

lib/features/label-editing/LabelEditingProvider.js

@@ -149,8 +149,7 @@ export default function LabelEditingProvider(
 
   function activateDirectEdit(element, force) {
     if (force ||
-        isAny(element, [ 'bpmn:Task', 'bpmn:TextAnnotation', 'bpmn:Participant' ]) ||
-        isCollapsedSubProcess(element)) {
+        isAny(element, [ 'bpmn:Activity', 'bpmn:Event', 'bpmn:TextAnnotation', 'bpmn:Participant' ])) {
 
       directEditing.activate(element);
     }

test/spec/features/label-editing/LabelEditingProviderSpec.js

@@ -573,8 +573,8 @@ describe('features - label-editing', function() {
 
     describe('on element creation', function() {
 
-      function createTaskElement(context) {
-        var shape = elementFactory.create('shape', { type: 'bpmn:Task' }),
+      function createElement(type, context) {
+        var shape = elementFactory.create('shape', { type: type }),
             parent = elementRegistry.get('SubProcess_1'),
             parentGfx = elementRegistry.getGraphics(parent);
 
@@ -587,6 +587,10 @@ describe('features - label-editing', function() {
         dragging.end();
       }
 
+      function createTaskElement(context) {
+        createElement('bpmn:Task', context);
+      }
+
       function createParticipant() {
 
         var collaboration = elementRegistry.get('Collaboration_1o0amh9'),
@@ -625,6 +629,117 @@ describe('features - label-editing', function() {
           expect(directEditing.isActive()).to.be.true;
         });
 
+
+        it('on StartEvent creation', function() {
+
+          // when
+          createElement('bpmn:StartEvent');
+
+          // then
+          expect(directEditing.isActive()).to.be.true;
+        });
+
+
+        it('on EndEvent creation', function() {
+
+          // when
+          createElement('bpmn:EndEvent');
+
+          // then
+          expect(directEditing.isActive()).to.be.true;
+        });
+
+
+        it('on IntermediateThrowEvent creation', function() {
+
+          // when
+          createElement('bpmn:IntermediateThrowEvent');
+
+          // then
+          expect(directEditing.isActive()).to.be.true;
+        });
+
+
+        it('on CallActivity creation', function() {
+
+          // when
+          createElement('bpmn:CallActivity');
+
+          // then
+          expect(directEditing.isActive()).to.be.true;
+        });
+
+        it('on subProcess creation', function() {
+
+          // when
+          createElement('bpmn:SubProcess');
+
+          // then
+          expect(directEditing.isActive()).to.be.true;
+        });
+
+        it('on adHocSubProcess creation', function() {
+
+          // when
+          createElement('bpmn:AdHocSubProcess');
+
+          // then
+          expect(directEditing.isActive()).to.be.true;
+        });
+
+      });
+
+      describe('should NOT activate', function() {
+
+        it('on ExclusiveGateway creation', function() {
+
+          // when
+          createElement('bpmn:ExclusiveGateway');
+
+          // then
+          expect(directEditing.isActive()).to.be.false;
+        });
+
+
+        it('on ParallelGateway creation', function() {
+
+          // when
+          createElement('bpmn:ParallelGateway');
+
+          // then
+          expect(directEditing.isActive()).to.be.false;
+        });
+
+
+        it('on InclusiveGateway creation', function() {
+
+          // when
+          createElement('bpmn:InclusiveGateway');
+
+          // then
+          expect(directEditing.isActive()).to.be.false;
+        });
+
+
+        it('on ComplexGateway creation', function() {
+
+          // when
+          createElement('bpmn:ComplexGateway');
+
+          // then
+          expect(directEditing.isActive()).to.be.false;
+        });
+
+
+        it('on EventBasedGateway creation', function() {
+
+          // when
+          createElement('bpmn:EventBasedGateway');
+
+          // then
+          expect(directEditing.isActive()).to.be.false;
+        });
+
       });