-
Notifications
You must be signed in to change notification settings - Fork 45
Housekeeping #204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Housekeeping #204
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This is a housekeeping PR that updates several major dependencies to their latest versions, including chai@6, bpmn-moddle@10, and min-dash@5. The main code change involves updating import/require statements for bpmn-moddle to use named exports instead of default exports, which is a breaking change introduced in bpmn-moddle v10.
Changes:
- Updated
bpmn-moddlefrom v9 to v10, requiring changes to all import/require statements to use named export{ BpmnModdle } - Updated
chaifrom v4 to v6,min-dashfrom v4 to v5, and several other dev dependencies - Removed unnecessary
/* eslint-env node */comment from rollup config file that uses ESM syntax
Reviewed changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/spec/traverse-spec.mjs | Updated import to use named export { BpmnModdle } |
| test/spec/testers/rule-tester-spec.mjs | Updated import to use named export { BpmnModdle } |
| test/integration/bundling/rollup.config.js | Removed unnecessary eslint-env comment from ESM file |
| package.json | Updated dependency versions for chai, bpmn-moddle, min-dash, pluralize, and dev dependencies |
| package-lock.json | Lockfile updates reflecting new dependency versions and their transitive dependencies |
| lib/testers/helper.js | Updated require to use named export { BpmnModdle } |
| bin/bpmnlint.js | Updated require to use named export { BpmnModdle } |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Thank you |
Proposed Changes
Standard housekeeping, including updates to ESM only libraries (we are targeting Node >= 20.12):
chai@6bpmn-moddle@10min-dash@5Checklist
Ensure you provide everything we need to review your contribution:
Closes {LINK_TO_ISSUE}orRelated to {LINK_TO_ISSUE}@bpmn-io/srtool