dmn-js: Viewers index.js: Use Viewer named exports to improve #946
Open
BrianJVarley wants to merge 4 commits intobpmn-io:developfrom
Open
dmn-js: Viewers index.js: Use Viewer named exports to improve #946BrianJVarley wants to merge 4 commits intobpmn-io:developfrom
BrianJVarley wants to merge 4 commits intobpmn-io:developfrom
Conversation
Member
|
Cf. #945 (comment) |
Contributor
Author
|
Feel free to close this, as you mentioned it needs a discussion. |
2f03601 to
2f60f02
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Related to {I945}
Exporting these classes instead of just default has some benefits for consumers. We don't need to use the long import path
import Viewer from 'dmn-js/lib/NavigatedViewer'insteadimport { NavigatedViewer } from 'dmn-js';. It also means you don't need to re-alias the Viewer when importing.For example with named exports:
Steps to reproduce the behavior:
Import NavigatedViewer using named import -
import { NavigatedViewer } from 'dmn-js';Import is undefined, only default import exists with internal path -
import Viewer from 'dmn-js/lib/NavigatedViewer