fix: cursor jumps when editing definition properties

[L2jLiga]

When definition properties are edited it fires Modeling#updateProperties. This method fires command element.updateProperties via commandStack to update element, same time DrdUpdater is subscribed to this command and do DefinitionPropertiesView#update when it executed.

When DefinitionPropertiesView#update is called it updates textContent of corresponding elements unconditionally which leads to cursor jump. In order to workaround issue with jumping cursor I've added condition that checks if element currently in focus and if so it prevent update of element content

Fixes #951
Fixes #274

Proposed Changes

Checklist

To ensure you provided everything we need to look at your PR:

• Brief textual description of the changes present
• Visual demo attached
• Steps to try out present, i.e. using the @bpmn-io/sr tool
• Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}

[nikku]

In order to workaround issue with jumping cursor I've added condition that checks if element currently in focus and if so it prevent update of element content

As you mention, this is a workaround. Alternatives could be:

• Prevent saving of the intermediate update
• Ensure we properly update/preserve the cursor, if the element is present (ref)
• Only forcefully update if textContent !== newTextContent

Consider the discussion on #951. We want to first understand what we build, and two options are at play.

[L2jLiga]

Consider the discussion on #951. We want to first understand what we build, and two options are at play.

Sure, when I started working on this issue there weren't any discussion atm, now I see you've discussed, let me add my few thoughts :)

• Ensure we properly update/preserve the cursor, if the element is present (ref)
• Only forcefully update if textContent !== newTextContent

This two are actually not an option due to trimming value. It will lead to cursor jumps in case when user enter space character at begining or at the end of line

• Prevent saving of the intermediate update

I think this is best option, it will work similar to proposed changes

[jarekdanielak]

@L2jLiga will you continue working on this?

[L2jLiga]

Hi @jarekdanielak, I could but currently expectations are not clear for me. Proposed changes already fixes both issues by disabling field value update while it's in focus.

From #951 I see two another solutions proposed - completely disable intermediate value emission or start using selection-update to fix input behavior. As @nikku said

Consider the discussion on #951. We want to first understand what we build, and two options are at play.

So atm I'm just waiting for any further disscussions to understand which solution I have to implement, sorry if I understand this wrong :)

[nikku]

@jarekdanielak please follow up. @L2jLiga, sorry for the long wait time.

[jarekdanielak]

From the proposed solutions, only updating the value on blur seems the most straight-forward and follows our practice, e.g. updating values in the properties panel.

@L2jLiga I haven't digged into the dmn-js implementation, but I would expect the solution to only trigger the update function on the blur event, instead of constantly triggering it and checking for the focused element inside of it.