Prepare for diagram-js@9 / browser native focus handling#311
Draft
Prepare for diagram-js@9 / browser native focus handling#311
diagram-js@9 / browser native focus handling#311Conversation
Merged
Contributor
pinussilvestrus
left a comment
pinussilvestrus
left a comment
There was a problem hiding this comment.
I tested it out on Mac Chrome & Safari, works like a charm from what I see ❤️
(A better fix would be using proper event delegation, but OK...)
nikku
changed the title
diagram-js@9diagram-js@9 / browser native focus handling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements browser native selection + keyboard binding following bpmn-io/diagram-js#662.
The form playground is the best example what browser native focus handling can acomplish: Each focusable element has it's own keyboard shortcuts; undo/redo works independently across all "editors":
Try it out via