fix: always return variables context in getResultContext#58
Merged
Conversation
Member
|
@barmac How does the problem manifest? I'd like to verify the fix E2E. I.e. would this fail previously?
Desktop Modeler v5.39.0
Preview environmentSpun up using
➡️ I see that |
nikku
reviewed
Sep 29, 2025
Member
Author
In the current nightly, you get an unhandled error once you create an expression broken before first variable name, e.g. via ai agent connector: Screen.Recording.2025-09-30.at.09.34.05.mov |
ea90d11 to
a69f88e
Compare
Member
Author
|
I've added |
nikku
approved these changes
Sep 30, 2025
Member
nikku
left a comment
There was a problem hiding this comment.
I can confirm that the reported bug is fixed, and that test cases are present.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Proposed Changes
This changes the variables tracking so that we don't fail when expression cannot be parsed at all (#57). For a long broken expression, we entered
ContextTracker#reduceand collected "variables" via first call. But for an immediately broken expression, we returnednullwhich broke the mechanism. Perhaps we could have avoided this problem with proper type checking.Try out via:
Checklist
To ensure you provided everything we need to look at your PR:
@bpmn-io/srtoolCloses {LINK_TO_ISSUE}orRelated to {LINK_TO_ISSUE}