Merged
Conversation
- Migrate to pyproject.toml (PEP 517/621) with setuptools, remove setup.py - Add rich dependency for terminal colors, replace django.utils.termcolors - Add pytest test suite with Django-agnostic tests - Add GitHub Actions CI for Python 3.10-3.14, Django 4.2/5.2 - Add uv for dependency management with uv.lock - Deprecate legacy RainbowTestSuiteRunner (Django <1.8) - Modernize code: super() without args, remove Python 2 headers - Update README and AGENTS.md for new workflow - Bump version to 0.7.0
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request aims to modernize django-rainbowtests to contemporary packaging and development standards. The changes include migrating from setup.py to pyproject.toml, adopting uv for dependency management, implementing pytest-based tests, adding GitHub Actions CI, and switching from Django's termcolors to the rich library for colorized output.
Changes:
- Migrated packaging from setup.py to pyproject.toml with PEP 517/621 standards
- Added pytest-based test suite with Django configuration in tests/conftest.py
- Introduced GitHub Actions CI workflow for automated testing across Python/Django versions
- Replaced django.utils.termcolors with rich library for terminal color output
- Modernized Python code (removed encoding headers, updated to super(), improved docstrings)
- Converted documentation from RST to Markdown format
- Added AGENTS.md and PLAN.md for development guidance
Reviewed changes
Copilot reviewed 22 out of 24 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| uv.lock | New lock file for uv dependency management (contains critical version issues) |
| pyproject.toml | New packaging configuration replacing setup.py (references non-existent versions) |
| setup.py | Removed in favor of pyproject.toml |
| tests/*.py | New pytest-based test suite with Django integration tests |
| tests/conftest.py | Django configuration for pytest |
| rainbowtests/colors.py | Refactored to use rich instead of django.utils.termcolors |
| rainbowtests/test/runner.py | Modernized with super() calls and improved docstrings |
| rainbowtests/test/core.py | Modernized Python code and fixed docstring |
| rainbowtests/test/simple.py | Converted to deprecated stub with clear error message |
| rainbowtests/init.py | Version bumped to 0.7.0 |
| README.md | New Markdown documentation replacing README.rst |
| README.rst | Removed |
| AGENTS.md | New AI agent development guidelines |
| PLAN.md | New implementation plan document |
| AUTHORS.md | Converted from AUTHORS.rst to Markdown |
| LICENSE.md | Updated with MIT header and year |
| MANIFEST.in | Updated to reference .md files instead of .rst/.txt |
| .github/workflows/ci.yml | New CI workflow for testing across Python/Django matrix |
Comments suppressed due to low confidence (1)
LICENSE.md:3
- The copyright year is listed as 2026, but the original copyright was 2016. Copyright notices should typically preserve the original year and optionally add the current year as a range (e.g., "Copyright (c) 2016-2026"). Replacing the original year entirely removes historical copyright information.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
@bradmontgomery I've opened a new pull request, #14, to work on those changes. Once the pull request is ready, I'll request review from you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A number of updates mainly to bring this project up to modern standards:
AGENTS.mdfile.