Refactor rating selection logic using .closest() for better UX and maintainability#263
Open
qingning7 wants to merge 1 commit intobradtraversy:masterfrom
Open
Refactor rating selection logic using .closest() for better UX and maintainability#263qingning7 wants to merge 1 commit intobradtraversy:masterfrom
qingning7 wants to merge 1 commit intobradtraversy:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: The previous event listener logic relied on strict DOM structure patterns (using parentNode and nextElementSibling). This caused the feedback selection to be unreliable—clicks on certain padding areas or specific child elements often failed to trigger the active state, leading to a "laggy" or "unresponsive" user experience.
Solution: Refactored the click event handler using the Element.closest() method.
Key Changes:
Testing: Verified that the 'active' class toggles correctly on all screen sizes and that the selectedRating value is captured accurately regardless of where the user clicks within the rating element.