Skip to content

Fix Validate Numberguesser #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
VaNaChiMa wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix Validate Numberguesser #23

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions numberguesser/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,11 +36,6 @@ game.addEventListener('mousedown', function(e){
guessBtn.addEventListener('click', function(){
let guess = parseInt(guessInput.value);

// Validate
if(isNaN(guess) || guess < min || guess > max){
setMessage(`Please enter a number between ${min} and ${max}`, 'red');
}

// Check if won
if(guess === winningNum){
// Game over - won
Expand All @@ -66,6 +61,11 @@ guessBtn.addEventListener('click', function(){
setMessage(`${guess} is not correct, ${guessesLeft} guesses left`, 'red');
}
}

// Validate
if(isNaN(guess) || guess < min || guess > max) {
setMessage(`Please enter a number between ${min} and ${max}`, 'red');
}
});

// Game over
Expand Down