FIX - postman testing issue gives error if {"admin": false} is not included in json body #214
Open
TracyChacon wants to merge 1 commit intobradtraversy:masterfrom
Open
FIX - postman testing issue gives error if {"admin": false} is not included in json body #214TracyChacon wants to merge 1 commit intobradtraversy:masterfrom
TracyChacon wants to merge 1 commit intobradtraversy:masterfrom
Conversation
This makes so that the ```isAdmin``` value can now be updated
Change to line 153 from :
user.isAdmin = req.body.isAdmin
To:
user.isAdmin = Object.is(req.body.isAdmin, undefined)
? user.isAdmin
: req.body.isAdmin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DETAILS
userController.jsfile, line 153, inside the ````updateUser``` function.ISSUE
When testing the backend using postman with the code
user.isAdmin = req.body.isAdmininuserConroller.jsthe below error error appearsisAdminis required.","stack": "ValidationError: User validation failed: isAdmin: Path
isAdminis required.\n at model.Document.invalidateUSECASE
The following code in the body section of postman causes the the error
{ "name": "jane dolittle" }TEMP FIX
An ad hoc fix is including the
isAdminvalue. The below code allows the tester to update user values.{ "name": "jane dolittle", "isAdmin": false }PROPOSED CHANGE
The proposed code change makes it so that you don't need to include the
isAdminvalue in the JSON to fix the issue.Change, in
updateUser()function, line 153 from :To: