Skip to content

fix build process to enable coro in vcpkg#1399

Merged
braindigitalis merged 1 commit intodevfrom
fix_coro_vcpkg
Mar 8, 2025
Merged

fix build process to enable coro in vcpkg#1399
braindigitalis merged 1 commit intodevfrom
fix_coro_vcpkg

Conversation

@braindigitalis
Copy link
Contributor

Coro would not build in vcpkg as the section to enable it was never copy and pasted over when we made it on by default. vcpkg never had coro.

Code change checklist

  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • My code follows the coding style guide.
  • I tested that my change works before raising the PR.
  • I have ensured that I did not break any existing API calls.
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight.

@netlify
Copy link

netlify bot commented Mar 8, 2025

Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit aaf5935
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/67cc2fbdaa7b69000804e08c
😎 Deploy Preview https://deploy-preview-1399--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added build Issue or Pull Request related to the build process packaging labels Mar 8, 2025
Copy link
Contributor

@Jaskowicz1 Jaskowicz1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we not maybe put the coro stuff in it's own CMake file?

We're repeating stuff that we could potentially change, and if we don't copy it over to either one, the one we forget to update will obviously be missing stuff.

Copy link
Member

@RealTimeChris RealTimeChris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. As always lol.

@braindigitalis
Copy link
Contributor Author

Should we not maybe put the coro stuff in it's own CMake file?

We're repeating stuff that we could potentially change, and if we don't copy it over to either one, the one we forget to update will obviously be missing stuff.

in the case of vcpkg it has its own cmakefile because things work differently there. Most stuff is hard coded to enabled. for example, the target names are also different.

@braindigitalis braindigitalis merged commit 3c3a546 into dev Mar 8, 2025
84 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Issue or Pull Request related to the build process packaging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants