Skip to content

security: bump minimum tls version for openssl to TLS 1.3#1405

Merged
braindigitalis merged 1 commit intodevfrom
tls_1_3
Mar 27, 2025
Merged

security: bump minimum tls version for openssl to TLS 1.3#1405
braindigitalis merged 1 commit intodevfrom
tls_1_3

Conversation

@braindigitalis
Copy link
Contributor

After raising this with Discord they have enabled support for TLS 1.3 on discord.media websocket endpoints. This now allows all of D++ to use TLS 1.3 as a minimum TLS version.

Unit tests now pass with this set.

Code change checklist

  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • My code follows the coding style guide.
  • I tested that my change works before raising the PR.
  • I have ensured that I did not break any existing API calls.
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight.

@braindigitalis braindigitalis self-assigned this Mar 25, 2025
@netlify
Copy link

netlify bot commented Mar 25, 2025

Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit c8b3cae
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/67e32aa52b0e1900081f0f2e
😎 Deploy Preview https://deploy-preview-1405--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the code Improvements or additions to code. label Mar 25, 2025
@braindigitalis
Copy link
Contributor Author

This also increases handshake performance significantly. I have not profiled this, but OpenSSL's own docs and third party sites document this handshake change:
image

@braindigitalis braindigitalis merged commit dfc6362 into dev Mar 27, 2025
84 checks passed
@braindigitalis braindigitalis deleted the tls_1_3 branch March 27, 2025 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code Improvements or additions to code.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants