refactor: make method and path in http_server_request protected instead of private#1423
Merged
braindigitalis merged 5 commits intobrainboxdotcc:devfrom Apr 20, 2025
Merged
Conversation
Putting path and request_type to protected (making them available to retrieve in case of handle other request type than "POST")
✅ Deploy Preview for dpp-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
braindigitalis
approved these changes
Apr 20, 2025
Jaskowicz1
approved these changes
Apr 20, 2025
Contributor
|
@braindigitalis shouldn't the title should be refactor instead of feat? |
Contributor
|
looks good, we will merge to dev as soon as ci finishes, thanks for your first contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Putting path and request_type to protected (making them available to retrieve in case of handle other request type than "POST")
Code change checklist