Skip to content

refactor: make method and path in http_server_request protected instead of private#1423

Merged
braindigitalis merged 5 commits intobrainboxdotcc:devfrom
garder500:master
Apr 20, 2025
Merged

refactor: make method and path in http_server_request protected instead of private#1423
braindigitalis merged 5 commits intobrainboxdotcc:devfrom
garder500:master

Conversation

@garder500
Copy link
Contributor

Putting path and request_type to protected (making them available to retrieve in case of handle other request type than "POST")

Code change checklist

  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • My code follows the coding style guide.
  • I tested that my change works before raising the PR.
  • I have ensured that I did not break any existing API calls.
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight.

Putting path and request_type to protected (making them available to retrieve in case of handle other request type than "POST")
@CLAassistant
Copy link

CLAassistant commented Apr 20, 2025

CLA assistant check
All committers have signed the CLA.

@netlify
Copy link

netlify bot commented Apr 20, 2025

Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit 09da71e
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/680518ea2b8deb000881386d
😎 Deploy Preview https://deploy-preview-1423--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added documentation Improvements or additions to documentation code Improvements or additions to code. labels Apr 20, 2025
@braindigitalis braindigitalis changed the title Update http_server_request.h feat: make method and path in http_server_request protected instead of private Apr 20, 2025
@Jaskowicz1
Copy link
Contributor

@braindigitalis shouldn't the title should be refactor instead of feat?

@garder500 garder500 changed the title feat: make method and path in http_server_request protected instead of private refactor: make method and path in http_server_request protected instead of private Apr 20, 2025
@braindigitalis
Copy link
Contributor

looks good, we will merge to dev as soon as ci finishes, thanks for your first contribution!

@braindigitalis braindigitalis merged commit c6bcab5 into brainboxdotcc:dev Apr 20, 2025
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code Improvements or additions to code. documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants