fix: json parsing issues with string arrays in dpp::application#1426
Merged
braindigitalis merged 1 commit intobrainboxdotcc:devfrom Apr 28, 2025
Merged
fix: json parsing issues with string arrays in dpp::application#1426braindigitalis merged 1 commit intobrainboxdotcc:devfrom
braindigitalis merged 1 commit intobrainboxdotcc:devfrom
Conversation
✅ Deploy Preview for dpp-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Contributor
|
Feel like we should have CI check this stuff if there's been issues with it, just so we can catch it. |
braindigitalis
approved these changes
Apr 26, 2025
Contributor
lets just add unit tests for it |
Contributor
yeah that's what I mean lol |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previously used method
basic_json::to_stringadds quotation marks around the string when parsing. Replacedbasic_json::to_stringwithbasic_json::get<std::string>.I noticed this issue in
dpp::applicationand also adjusted it indpp::emojianddpp::integration.Code change checklist