Skip to content

fix: json parsing issues with string arrays in dpp::application#1426

Merged
braindigitalis merged 1 commit intobrainboxdotcc:devfrom
Commandserver:dev
Apr 28, 2025
Merged

fix: json parsing issues with string arrays in dpp::application#1426
braindigitalis merged 1 commit intobrainboxdotcc:devfrom
Commandserver:dev

Conversation

@Commandserver
Copy link
Member

The previously used method basic_json::to_string adds quotation marks around the string when parsing. Replaced basic_json::to_string with basic_json::get<std::string>.

I noticed this issue in dpp::application and also adjusted it in dpp::emoji and dpp::integration.

Code change checklist

  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • My code follows the coding style guide.
  • I tested that my change works before raising the PR.
  • I have ensured that I did not break any existing API calls.
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight.

@github-actions github-actions bot added the code Improvements or additions to code. label Apr 26, 2025
@netlify
Copy link

netlify bot commented Apr 26, 2025

Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit 4d21c94
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/680ceee4747d07000811d0a1
😎 Deploy Preview https://deploy-preview-1426--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Jaskowicz1
Copy link
Contributor

Feel like we should have CI check this stuff if there's been issues with it, just so we can catch it.

@braindigitalis
Copy link
Contributor

Feel like we should have CI check this stuff if there's been issues with it, just so we can catch it.

lets just add unit tests for it

@Jaskowicz1
Copy link
Contributor

Feel like we should have CI check this stuff if there's been issues with it, just so we can catch it.

lets just add unit tests for it

yeah that's what I mean lol

@braindigitalis braindigitalis merged commit bdd597b into brainboxdotcc:dev Apr 28, 2025
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code Improvements or additions to code.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants