feat: server tags support#1477
Merged
braindigitalis merged 4 commits intobrainboxdotcc:devfrom Sep 11, 2025
Merged
Conversation
✅ Deploy Preview for dpp-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Mishura4
reviewed
Aug 18, 2025
Mishura4
previously requested changes
Aug 18, 2025
Member
Mishura4
left a comment
There was a problem hiding this comment.
I'm only blocking on the constructor.
For the repetitive json lookups i'll pretend it doesn't exist for now
Co-authored-by: Miuna <809711+Mishura4@users.noreply.github.com>
Good to go with latest change, I can't approve the json stuff but i'll let it slide 🙈
Contributor
Author
|
By the way, there is Is in-code stuff mismatched with docs intended or...? |
Member
|
@braindigitalis ping |
braindigitalis
approved these changes
Sep 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support for Server Tags
Pretty simple and straightforward. The only thing I'm unsure about,
identity_enabled's description mentions some possible null value, but judging bybool_not_nullit will default to false in that case, which is right behavior in my opinionCode change checklist