Squiz/FunctionDeclarationArgumentSpacing: bug fix / SpacingAfterReference does not flag new lines

A `T_WHITESPACE` token only containing new line characters will have its token `'length'` set to `0`.

This means that if there was a new line after a reference token, the sniff would not report it.

Fixed now.

Also note that, as the sniff demands no whitespace after a reference operator, we don't need the extra check for `$gap !== 0` as we already know that the next token is a whitespace token and needs to be flagged.

Includes tests.

Author: jrfnl

src/Standards/Squiz/Sniffs/Functions/FunctionDeclarationArgumentSpacingSniff.php

@@ -149,12 +149,12 @@ public function processBracket($phpcsFile, $openBracket)
             if ($param['pass_by_reference'] === true) {
                 $refToken = $param['reference_token'];
 
-                $gap = 0;
                 if ($tokens[($refToken + 1)]['code'] === T_WHITESPACE) {
                     $gap = $tokens[($refToken + 1)]['length'];
-                }
+                    if ($tokens[$refToken]['line'] !== $tokens[($refToken + 2)]['line']) {
+                        $gap = 'newline';
+                    }
 
-                if ($gap !== 0) {
                     $error = 'Expected 0 spaces after reference operator for argument "%s"; %s found';
                     $data  = [
                         $param['name'],

src/Standards/Squiz/Tests/Functions/FunctionDeclarationArgumentSpacingUnitTest.inc

@@ -118,3 +118,15 @@ function spacingBetweenParenthesesShouldBeFixedInOneGo(
 
 
     ) {}
+
+function newlineAfterReferenceShouldBeFlaggedAndFixed(
+    &
+
+    $param
+) {}
+
+function newlineAfterReferenceFixerRespectsComment(
+    &
+    // comment
+    $param
+) {}

src/Standards/Squiz/Tests/Functions/FunctionDeclarationArgumentSpacingUnitTest.inc.fixed

@@ -113,3 +113,12 @@ fn ($a, $b=null) => $a($b);
 function multipleWhitespaceTokensAfterType(int $number) {}
 
 function spacingBetweenParenthesesShouldBeFixedInOneGo() {}
+
+function newlineAfterReferenceShouldBeFlaggedAndFixed(
+    &$param
+) {}
+
+function newlineAfterReferenceFixerRespectsComment(
+    &// comment
+    $param
+) {}

src/Standards/Squiz/Tests/Functions/FunctionDeclarationArgumentSpacingUnitTest.php

@@ -70,6 +70,8 @@ public function getErrorList()
             111 => 3,
             113 => 1,
             117 => 1,
+            123 => 1,
+            129 => 1,
         ];
 
     }//end getErrorList()