-
Notifications
You must be signed in to change notification settings - Fork 59
update script for 2022 version of allen, remove allensdk #727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
25 micron file |
for more information, see https://pre-commit.ci
…nglobe-atlasapi into allen-mouse-2022
|
The allen have done a really fantastic job making smooth meshes. I cant really get comparable quality. I'll just reuse their meshes and restrict the mesh generation to regions that have been updated. Does anyone know if they have open sourced their mesh generation pipeline as I think it could be really useful, for other atlases also. |
… Valuable as all structures must be provided when constructing the tree for parent regions
|
IIRC their mesh generation isn't fully automatic. The reason the meshes are so nice is because lots of work went into smoothing them manually. |
|
Hmm so the create_region_mesh function expects a tuple instead of normal arguments (this is for multiprocessing purposes). This is ok but it makes it hard to add new optional arguments to it. Could we instead make a wrapper function which takes a tuple and calls the function which now has normal arguments? |
|
Hey @PolarBean, probably best to create a new issue and we can discuss. The mesh generation functions are long overdue some more thought. @brainglobe is on holiday for two weeks now though, so we'll take a look at this PR in Jan. |
|
ah ok. I'll make a new issue. I modified it pretty minimally so that I could add the new argument whilst keeping it backwards compatible and keep all of the tests passing. No rush at all in merging this, happy christmas |
|
Hey @PolarBean, just getting back to this. A couple of questions:
|
|
yeah ill generate 50 and 100, good catch. Also yes, I'll make a separate pr for the mesh generation changes. |



Description
Here we add the 2022 version of the Allen. We also remove the allensdk as it is becoming increasingly incompatible with other parts of brainglobe (getting it to work in Python3.13 while supporting threading was too hard)
What is this PR
References
#233
Does this PR require an update to the documentation?
Yes we will update the atlas docs.
Checklist: