Skip to content

Conversation

@PolarBean
Copy link
Member

@PolarBean PolarBean commented Dec 17, 2025

Description

Here we add the 2022 version of the Allen. We also remove the allensdk as it is becoming increasingly incompatible with other parts of brainglobe (getting it to work in Python3.13 while supporting threading was too hard)
What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

References

#233

Does this PR require an update to the documentation?

Yes we will update the atlas docs.

Checklist:

  • The code has been tested locally
  • Tests have been added to cover all new functionality (unit & integration)
  • The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

@PolarBean
Copy link
Member Author

PolarBean commented Dec 17, 2025

25 micron file
removed as ill provide a version with smoothed meshes

@PolarBean
Copy link
Member Author

image works at 25um. I'll post the 10um when its done.

@PolarBean
Copy link
Member Author

The allen have done a really fantastic job making smooth meshes. I cant really get comparable quality. I'll just reuse their meshes and restrict the mesh generation to regions that have been updated. Does anyone know if they have open sourced their mesh generation pipeline as I think it could be really useful, for other atlases also.

… Valuable as all structures must be provided when constructing the tree for parent regions
@adamltyson
Copy link
Member

IIRC their mesh generation isn't fully automatic. The reason the meshes are so nice is because lots of work went into smoothing them manually.

@PolarBean
Copy link
Member Author

@PolarBean
Copy link
Member Author

both work in napari
image
image

@PolarBean PolarBean marked this pull request as ready for review December 18, 2025 15:45
@PolarBean PolarBean marked this pull request as draft December 18, 2025 16:51
@PolarBean
Copy link
Member Author

PolarBean commented Dec 18, 2025

Hmm so the create_region_mesh function expects a tuple instead of normal arguments (this is for multiprocessing purposes). This is ok but it makes it hard to add new optional arguments to it. Could we instead make a wrapper function which takes a tuple and calls the function which now has normal arguments?

@PolarBean PolarBean marked this pull request as ready for review December 18, 2025 18:11
@adamltyson
Copy link
Member

adamltyson commented Dec 19, 2025

Hey @PolarBean, probably best to create a new issue and we can discuss. The mesh generation functions are long overdue some more thought. @brainglobe is on holiday for two weeks now though, so we'll take a look at this PR in Jan.

@PolarBean
Copy link
Member Author

ah ok. I'll make a new issue. I modified it pretty minimally so that I could add the new argument whilst keeping it backwards compatible and keep all of the tests passing. No rush at all in merging this, happy christmas

@adamltyson
Copy link
Member

Hey @PolarBean, just getting back to this. A couple of questions:

@PolarBean
Copy link
Member Author

yeah ill generate 50 and 100, good catch. Also yes, I'll make a separate pr for the mesh generation changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants