Fix crash when no cell candidates are detected#595
Open
tanishaa7 wants to merge 3 commits intobrainglobe:mainfrom
Open
Fix crash when no cell candidates are detected#595tanishaa7 wants to merge 3 commits intobrainglobe:mainfrom
tanishaa7 wants to merge 3 commits intobrainglobe:mainfrom
Conversation
aymuos15
reviewed
Mar 4, 2026
cellfinder/core/train/train_yaml.py
Outdated
| ) | ||
|
|
||
|
|
||
| class EpochEndCallback(keras.callbacks.Callback): |
There was a problem hiding this comment.
Not sure if you need this new class. Keras provides a built-in LambdaCallback . Something like:
callbacks.append(LambdaCallback(
on_epoch_end=lambda epoch, logs: progress_callback(
f"Training epoch {epoch+1}/{epochs}", epoch+1, epochs
)
))There was a problem hiding this comment.
Just saw that the class pattern is used elsewhere as well. I would still keep this flagged, I would think the simple append is better.
Author
There was a problem hiding this comment.
Thanks for the review, @aymuos15. You're right that LambdaCallback is cleaner. I changed it and add the new code. Thank you. Please let me know if it is fine now
tanishaa7
force-pushed
the
fix-empty-candidates-344
branch
from
d9bf4fd to
0b5e05e
Compare
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a crash that occurs when no cell candidates are detected.
Closes #344