fix: replace esc_attr() misuse with proper input sanitization#224
Merged
sushmak02 merged 1 commit intorelease-candidatefrom Feb 24, 2026
Merged
fix: replace esc_attr() misuse with proper input sanitization#224sushmak02 merged 1 commit intorelease-candidatefrom
sushmak02 merged 1 commit intorelease-candidatefrom
Conversation
- Replace esc_attr() on $_POST/$_GET with sanitize_text_field(), absint(), or intval() depending on data type - Add wp_unslash() before sanitization on superglobal access - Fix nonce values to use sanitize_text_field(wp_unslash()) before wp_verify_nonce() - Fix post IDs to use absint() instead of esc_attr() - Fix star ratings to use intval() instead of esc_attr() Fixes #219
sushmak02
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
esc_attr()on$_POST/$_GETwithsanitize_text_field(),absint(), orintval()depending on data typewp_unslash()before sanitization on superglobal accesssanitize_text_field(wp_unslash())beforewp_verify_nonce()absint()instead ofesc_attr()intval()instead ofesc_attr()Files changed
init.php— meta box save, file upload, oEmbed handlerfunctions.php— rating AJAX handlersadmin/index.php— settings reset handlerTest plan
Fixes #219