Add Billing With Purchase analytics tags

[anibalb2500]

Summary of changes

• Adding is_billing_agreement, and billing_plan_type to AnalyticsParamRepository so that it is sent with analytic events.
  • This is for observability over the Billing With Purchase feature, so we can properly distinguish these flows.
• Renamed existing isBillingAgreement to isVaultRequest in PayPalPaymentAuthRequestParams to be repurposed for these changes.

Checklist

• Added a changelog entry
• Relevant test coverage
• Tested and confirmed payment flows affected by this change are functioning as expected

Screenshots

075999814R484453G - had shouldRequestBillingAgreement as false, and did not set recurringBillingPlanType.
93A012420S1215734 - had shouldRequestBillingAgreement as true, and set recurringBillingPlanType to RECURRING

Authors

@anibalb2500

[saralvasquez]

Could I get some context on why this is being added? Why is it needed?

[anibalb2500]

Could I get some context on why this is being added? Why is it needed?

For the Billing With Purchase feature we need to tell analytics when the merchant requested a billing agreement (shouldRequestBillingAgreement == true) so our observability dashboards can separate those flows from regular checkout. Right now there isn’t a tag on analytics events that indicates whether the request was Billing With Purchase, so we can’t see that clearly on the merchant or PayPal app side. Adding billing_with_purchase to the analytics payload fixes that.

[saralvasquez]

🎉

[saralvasquez]

Looks like the one instrumentation test that is failing is the local payments test relating to the issue we are tracking. We'll go ahead a merge this when that issue is resolved

[jaxdesmarais]

I left some comments on the iOS PR - lets align on naming across both platforms

[anibalb2500]

@jaxdesmarais I responded to your comments and updated PR description with latest evidence. Are we still waiting on failing instrumentation tests to be fixed?

[jaxdesmarais]

Small nit to add a space between FPTI_KEYs and FPTI_BATCH_KEYs

[anibalb2500]

Done.