Coroutines - convert ApiClient tokenize functions to suspend#1533
Merged
saralvasquez merged 7 commits intomainfrom Feb 24, 2026
Merged
Coroutines - convert ApiClient tokenize functions to suspend#1533saralvasquez merged 7 commits intomainfrom
saralvasquez merged 7 commits intomainfrom
Conversation
Dependency Review✅ No vulnerabilities found.Scanned FilesNone |
noguier
reviewed
Feb 19, 2026
| error: Exception? = null, | ||
| captureRequestBody: CapturingSlot<String>? = null | ||
| ): Pair<PayPalInternalClient, BraintreeClient> { | ||
| ): PayPalInternalClient { |
Contributor
There was a problem hiding this comment.
Why do we not need a pair<PayPalInternalClient, BraintreeClient> here anymore?
Contributor
Author
There was a problem hiding this comment.
Ah good eye! It was an unused variable that was throwing lint warnings forever and since I was already in there I decided to just clean it up. If you wanna take a look for yourself you can run the processes in the CI file and see what it says about that test file
tdchow
reviewed
Feb 19, 2026
BraintreeCore/src/main/java/com/braintreepayments/api/core/ApiClient.kt
Outdated
Show resolved
Hide resolved
BraintreeCore/src/main/java/com/braintreepayments/api/core/ApiClient.kt
Outdated
Show resolved
Hide resolved
noguier
approved these changes
Feb 20, 2026
tdchow
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
tokenizeGraphQLandtokenizeRESTto suspend functionsCardClient,PayPalInternalClient,VenmoAPI, andVisaCheckoutClientMockkApiClientBuilderto return the correct typesChecklist
Authors
@saralvasquez