Venmo compose button#1541
Merged
saperi22 merged 44 commits intoui-components-compose-supportfrom Mar 16, 2026
Merged
Conversation
…fully. The flow is broken.
Works end to end and shows a successful response.
Restrict view model and repository to library group. Make sure that handle return is called only after flow is launched.
saperi22
force-pushed
the
venmo-compose-smart-button
branch
from
f28e59c to
caad8d8
Compare
Base automatically changed from
compose-smart-button
to
ui-components-compose-support
March 11, 2026 18:21
tdchow
approved these changes
Mar 12, 2026
Contributor
|
Hmmm when testing on physical device I got the venmo flow to work, but then went to try to PayPal flow right after and when I click "Continue to Review Order" it sends me back to the demo app with "user did not complete PayPal flow" and the same thing happens for the venmo flow |
saralvasquez
approved these changes
Mar 16, 2026
Contributor
saralvasquez
left a comment
saralvasquez
left a comment
There was a problem hiding this comment.
Looks ready to me once the browser switch change is done being released!
noguier
reviewed
Mar 16, 2026
UIComponents/src/main/java/com/braintreepayments/api/uicomponents/compose/PayPalSmartButton.kt
Show resolved
Hide resolved
noguier
approved these changes
Mar 16, 2026
saperi22
merged commit 1008832
into
ui-components-compose-support
9 of 21 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Testing note:
BrowserSwitchActivityRegistryKeyin BrowserSwitchClient is the same for both and is causing an issue where PayPal flow result is delivered to Venmo flow as it was registered later.Checklist
Authors