reuse requests session when doing api calls #163
+32
−51
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As stated in https://requests.readthedocs.io/en/latest/user/advanced/#session-objects
This commit adjusts the initialization of the Http class and the configuration to create a session object that will be reused across different calls.
In addition
self.requests_session.proxies.update(requests.utils.getproxies())needs to be called only once so now the function is lighter in what it does.For the removed test I checked the commit that added it and I believe is not needed as the code behaves different, session is not closed now.
I have checked it against the tests in my project and seems to work properly too.
Related to #162
Checklist
python3 -m unittest discover tests/unit)