fix failing functional/smoke tests#140
Conversation
Co-authored-by: Adriana Machado <adrmachado@paypal.com>
Dependency ReviewThe following issues were found:
Scanned Files
|
| "@wdio/mocha-framework": "^7.25.2", | ||
| "@wdio/spec-reporter": "^7.25.1", | ||
| "@wdio/sync": "^7.25.2", | ||
| "@wdio/cli": "^9.21.1", |
There was a problem hiding this comment.
for future reference, since all the @wdio libraries are so closely tied, it's better to upgrade them in one go rather than trying to upgrade them independently. so it's recommended to run
npm install @wdio/cli@latest @wdio/local-runner@latest @wdio/mocha-framework@latest @wdio/spec-reporter@latest even though it's annoying to type out
| "async": "^3.2.5", | ||
| "browserify": "^17.0.0", | ||
| "chromedriver": "^133.0.1", | ||
| "chromedriver": "^143.0.1", |
There was a problem hiding this comment.
the error causing the pipeline builds to fail was Request failed with status 500 due to session not created: This version of ChromeDriver only supports Chrome version 133.
upgrading chromedriver as well as the @wdio packages fixed that problem.
spec/functional/popup-spec.js
Outdated
| browser.switchWindow("localhost:3099"); | ||
|
|
||
| browser.switchToFrame(2); | ||
| browser.switchFrame(2); |
There was a problem hiding this comment.
this is just paperwork -- the function name was deprecated and renamed
Co-authored-by: Adriana Machado <adrmachado@paypal.com>
e701b26 to
a22f4a6
Compare
Co-authored-by: Adriana Machado <adrmachado@paypal.com>
…onfig.json to have typing information for wdio. Ran Prettier.
Co-authored-by: Adriana Machado <adrmachado@paypal.com>
f8d9a7f to
f86cb78
Compare
Co-authored-by: Adriana Machado <adrmachado@paypal.com>
| "@wdio/local-runner": "^7.25.2", | ||
| "@wdio/mocha-framework": "^7.25.2", | ||
| "@wdio/spec-reporter": "^7.25.1", | ||
| "@wdio/sync": "^7.25.2", |
There was a problem hiding this comment.
we ended up removing @wdio/sync since it it not supported by > node 18. this means that we had to modify our tests to be explicitly asynchronous, but it'll be better in the long run
Co-authored-by: Zachary Nelson <nelsonz2021@gmail.com>
Summary of changes
Fix failing functional/smoke tests
Checklist
Reviewers
@braintree/team-sdk-js