[bugfix] remove test files from tsconfig (fixes #144)#145
Merged
adrmachado-public merged 1 commit intomainfrom Jan 30, 2026
Merged
[bugfix] remove test files from tsconfig (fixes #144)#145adrmachado-public merged 1 commit intomainfrom
adrmachado-public merged 1 commit intomainfrom
Conversation
adrmachado-public
changed the title
Dependency ReviewThe following issues were found:
Scanned Files
|
adrmachado-public
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Thanks to @Explorer-Carbon to finding this bug in the latest release. Including test files in the tsconfig introduced a bug where imported usages of this package did not have the correct entry point.
though we could direct the module to the correct entry point, we should probably never have included the test files in the build.
i also took the opportunity to try to auto fix some vulnerabilities in our dependency graph
Checklist
Authors
@adrmachado-public
Reviewers
@braintree/team-sdk-js