Skip to content

Conversation

@brandonweeks
Copy link
Owner

Fixes #9

Copy link

@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think this is a change in the right direction.

Did you want to look at the question of how servers should be matching CSR subjectAltName extensionRequest attributes with ACME order identifiers separately or was that part of my issue not well articulated? I think there's still room to make that aspect of the draft a bit tighter even after this update.

Comment on lines +94 to +99
The hardware module identity can be included in the Subject Alternate Name Extension using the HardwareModuleName form described in [RFC4108]. The HardwareModuleName is encoded as an otherName with the OID id-on-hardwareModuleName (1.3.6.1.5.5.7.8.4) and consists of:

- hwType: An OBJECT IDENTIFIER that identifies the type of hardware module
- hwSerialNum: An OCTET STRING containing the hardware module serial number

Clients MAY include this identifier in the certificate signing request (CSR). When included in a CSR, it MUST appear in an extensionRequest attribute [RFC2985] requesting a subjectAltName extension.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This new text looks good, but I think its a little more detailed than the equivalent Permanent Identifier text and it might be nice to aim for more symmetry between them. The things that stick out to me in this one vs the other are the mention of the otherName OID, and the extra clarity on the expected RFC 2985 CSR attribute.

I think the extra detail here is good, so probably backporting some of it to the preceding section might be the best way to go. WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

hardware-module identifier CSR encoding underspecified?

3 participants