Skip to content

Commit 30c497e

Browse files
committed
Updated disease uptime tracking to include Dread Plague, removed deprecated thresholds and Ebon Fever references
1 parent 53f29b8 commit 30c497e

File tree

3 files changed

+46
-94
lines changed

3 files changed

+46
-94
lines changed

src/analysis/retail/deathknight/unholy/CombatLogParser.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ import RuneTracker from './modules/core/RuneTracker';
1111
import SuddenDoom from './modules/talents/SuddenDoom';
1212
import RunicPowerDetails from './modules/core/RunicPowerDetails';
1313
import RunicPowerTracker from './modules/core/RunicPowerTracker';
14-
import VirulentPlagueEfficiency from './modules/features/VirulentPlagueEfficiency';
14+
import PlagueEfficiency from './modules/features/PlagueEfficiency';
1515
import SoulReaper from '../shared/talents/SoulReaper';
1616
import CommanderOfTheDead from './modules/talents/CommanderOfTheDead';
1717
import LesserGhoul from './modules/features/LesserGhoul';
@@ -29,7 +29,7 @@ class CombatLogParser extends CoreCombatLogParser {
2929
channeling: Channeling,
3030

3131
// Features
32-
virulentPlagueEfficiency: VirulentPlagueEfficiency,
32+
plagueEfficiency: PlagueEfficiency,
3333
lesserGhoul: LesserGhoul,
3434
unholyRuneForge: UnholyRuneForgeChecker,
3535

Lines changed: 44 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,44 @@
1+
import { formatPercentage } from 'common/format';
2+
import SPELLS from 'common/SPELLS';
3+
import UptimeIcon from 'interface/icons/Uptime';
4+
import Analyzer from 'parser/core/Analyzer';
5+
import Enemies from 'parser/shared/modules/Enemies';
6+
import BoringSpellValueText from 'parser/ui/BoringSpellValueText';
7+
import Statistic from 'parser/ui/Statistic';
8+
import STATISTIC_ORDER from 'parser/ui/STATISTIC_ORDER';
9+
10+
class PlagueEfficiency extends Analyzer {
11+
static dependencies = {
12+
enemies: Enemies,
13+
};
14+
15+
protected enemies!: Enemies;
16+
17+
get VirulentPlagueUptime() {
18+
return this.enemies.getBuffUptime(SPELLS.VIRULENT_PLAGUE.id) / this.owner.fightDuration;
19+
}
20+
21+
get DreadPlagueUptime() {
22+
return this.enemies.getBuffUptime(SPELLS.DREAD_PLAGUE.id) / this.owner.fightDuration;
23+
}
24+
25+
statistic() {
26+
return (
27+
<Statistic position={STATISTIC_ORDER.CORE(7)} size="flexible">
28+
<BoringSpellValueText spell={SPELLS.VIRULENT_PLAGUE.id}>
29+
<>
30+
<UptimeIcon /> {formatPercentage(this.VirulentPlagueUptime)}%{' '}
31+
<small>Disease Uptime</small>
32+
</>
33+
</BoringSpellValueText>
34+
<BoringSpellValueText spell={SPELLS.DREAD_PLAGUE.id}>
35+
<>
36+
<UptimeIcon /> {formatPercentage(this.DreadPlagueUptime)}% <small>Disease Uptime</small>
37+
</>
38+
</BoringSpellValueText>
39+
</Statistic>
40+
);
41+
}
42+
}
43+
44+
export default PlagueEfficiency;

src/analysis/retail/deathknight/unholy/modules/features/VirulentPlagueEfficiency.tsx

Lines changed: 0 additions & 92 deletions
This file was deleted.

0 commit comments

Comments
 (0)