Skip to content

Commit 5548b5a

Browse files
committed
Added changelog entry and final style cleanup
1 parent 30c497e commit 5548b5a

File tree

5 files changed

+9
-7
lines changed

5 files changed

+9
-7
lines changed
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,11 @@
11
import { change, date } from 'common/changelog';
2+
import SPELLS from 'common/SPELLS';
23
import { Brandrewsss } from 'CONTRIBUTORS';
34
import SpellLink from 'interface/SpellLink';
45
import TALENTS from 'common/TALENTS/deathknight';
56

67
export default [
8+
change(date(2026, 2, 17), <>Updated <SpellLink spell={TALENTS.SUDDEN_DOOM_TALENT} /> efficiency and <SpellLink spell={TALENTS.COMMANDER_OF_THE_DEAD_TALENT} /> pet tracking. Added <SpellLink spell={SPELLS.LESSER_GHOUL_BUFF} /> stack tracking and <SpellLink spell={SPELLS.DREAD_PLAGUE} /> disease uptime.</>, Brandrewsss),
79
change(date(2026, 2, 11), <>Added Cooldown Tracking and Throughput Tracker for <SpellLink spell={TALENTS.DARK_TRANSFORMATION_TALENT} />, <SpellLink spell={TALENTS.ARMY_OF_THE_DEAD_TALENT} />, and <SpellLink spell={TALENTS.PUTREFY_TALENT} />.</>, Brandrewsss),
810
change(date(2026, 2, 5), <>Initial Update for Midnight.</>, Brandrewsss),
911
];

src/analysis/retail/deathknight/unholy/modules/features/LesserGhoul.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import Events, {
99
import { formatPercentage } from 'common/format';
1010
import BoringSpellValueText from 'parser/ui/BoringSpellValueText';
1111
import Statistic from 'parser/ui/Statistic';
12-
import { STATISTIC_ORDER } from 'parser/ui/StatisticBox';
12+
import STATISTIC_ORDER from 'parser/ui/STATISTIC_ORDER';
1313

1414
const BUFF_DURATION_MS = 30000;
1515
const EXPIRE_BUFFER_MS = 100;

src/analysis/retail/deathknight/unholy/modules/features/PlagueEfficiency.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,11 @@ class PlagueEfficiency extends Analyzer {
1414

1515
protected enemies!: Enemies;
1616

17-
get VirulentPlagueUptime() {
17+
get virulentPlagueUptime() {
1818
return this.enemies.getBuffUptime(SPELLS.VIRULENT_PLAGUE.id) / this.owner.fightDuration;
1919
}
2020

21-
get DreadPlagueUptime() {
21+
get dreadPlagueUptime() {
2222
return this.enemies.getBuffUptime(SPELLS.DREAD_PLAGUE.id) / this.owner.fightDuration;
2323
}
2424

@@ -27,13 +27,13 @@ class PlagueEfficiency extends Analyzer {
2727
<Statistic position={STATISTIC_ORDER.CORE(7)} size="flexible">
2828
<BoringSpellValueText spell={SPELLS.VIRULENT_PLAGUE.id}>
2929
<>
30-
<UptimeIcon /> {formatPercentage(this.VirulentPlagueUptime)}%{' '}
30+
<UptimeIcon /> {formatPercentage(this.virulentPlagueUptime)}%{' '}
3131
<small>Disease Uptime</small>
3232
</>
3333
</BoringSpellValueText>
3434
<BoringSpellValueText spell={SPELLS.DREAD_PLAGUE.id}>
3535
<>
36-
<UptimeIcon /> {formatPercentage(this.DreadPlagueUptime)}% <small>Disease Uptime</small>
36+
<UptimeIcon /> {formatPercentage(this.dreadPlagueUptime)}% <small>Disease Uptime</small>
3737
</>
3838
</BoringSpellValueText>
3939
</Statistic>

src/analysis/retail/deathknight/unholy/modules/talents/SuddenDoom.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ import { ThresholdStyle } from 'parser/core/ParseResults';
1111
import { formatPercentage } from 'common/format';
1212
import BoringSpellValueText from 'parser/ui/BoringSpellValueText';
1313
import Statistic from 'parser/ui/Statistic';
14-
import { STATISTIC_ORDER } from 'parser/ui/StatisticBox';
14+
import STATISTIC_ORDER from 'parser/ui/STATISTIC_ORDER';
1515

1616
/* The Sudden Doom buff lasts 10 seconds. We use this to distinguish natural expiration
1717
(removal near the 10s mark) from consumption (removal mid-duration via DC/Epidemic).

src/common/SPELLS/deathknight.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -299,7 +299,7 @@ const spells = {
299299
icon: 'spell_shadow_fumble',
300300
},
301301

302-
// Summon event for Lesser Ghouls from regular gameplay (Festering Strike/Death Coil procs)
302+
// Summon event for Lesser Ghouls from regular gameplay (Scourge Strike consuming Festering Strike buff)
303303
LESSER_GHOUL: {
304304
id: 275430,
305305
name: 'Lesser Ghoul',

0 commit comments

Comments
 (0)