chore: fix a large number of spelling issues#2950
Open
sunnyraindy wants to merge 1 commit intobrave-intl:masterfrom
Open
chore: fix a large number of spelling issues#2950sunnyraindy wants to merge 1 commit intobrave-intl:masterfrom
sunnyraindy wants to merge 1 commit intobrave-intl:masterfrom
Conversation
mihaiplesa
approved these changes
Nov 17, 2025
Signed-off-by: sunnyraindy <sunnyraindy@outlook.com>
Author
|
@mihaiplesa Thanks for your review! If there's anything need I to do, please feel free to let me know. |
Contributor
|
We are just waiting for @clD11 to approve and merge. |
clD11
reviewed
Dec 5, 2025
| case timeLimitedV2: | ||
| redeemFn = s.cbClient.RedeemCredentialV3 | ||
| default: | ||
| return handlers.WrapError(fmt.Errorf("credential type %s not suppoted", kind), "unknown credential type %s", http.StatusBadRequest) |
Contributor
There was a problem hiding this comment.
This error and message is returned to clients so to be safe we should leave as is for now. In the past we have had issue with clients relying on the message it self to perform logic.
| ); err != nil { | ||
| sublogger.Error().Err(err). | ||
| Msg("failed to update wallets with new deposit destination") | ||
| return fmt.Errorf("error updating wallets with new deposit desintation: %w", err) |
Contributor
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix a large number of spelling issues
Type of Change
Tested Environments
Before Requesting Review
Manual Test Plan