Added retries for download external extensions.#1109
Open
Conversation
linhkikuchi
approved these changes
Jul 29, 2025
antonok-edm
reviewed
Jul 29, 2025
Collaborator
antonok-edm
left a comment
antonok-edm
left a comment
There was a problem hiding this comment.
We already have a "download with multiple retries" function code with in lib/utils; it only supports text body right now but I recommend using a shared internal implementation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we download extension from an external source, there can be failures (example), in this PR I've added the retry logic, it attempts to download extension 3 times with with 0s, 5s, 10s delay.