import adblock-resources repo as a library#972
Open
antonok-edm wants to merge 1 commit intomasterfrom
Open
Conversation
antonok-edm
force-pushed
the
adblock-resources-as-library
branch
from
aa754f5 to
d74dd7d
Compare
antonok-edm
force-pushed
the
adblock-resources-as-library
branch
from
d74dd7d to
ab69ccf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change means we can remove
dist/resources.jsonand the corresponding build step in theadblock-resourcesrepo.One annoyance is that
package-lock.jsonnow locksadblock-resourcesto a specific commit, so it will no longer be updated here automatically when resources are updated. Maybe we should add a version of the code inadblock-resourcesthat pulls the resources fromadblock-resources#masterrather than whatever's in-tree?