Skip to content

check HKDF return value in release builds to prevent zero-key signing#34332

Merged
diracdeltas merged 3 commits intomasterfrom
fix/hkdf
Feb 28, 2026
Merged

check HKDF return value in release builds to prevent zero-key signing#34332
diracdeltas merged 3 commits intomasterfrom
fix/hkdf

Conversation

@diracdeltas
Copy link
Member

@github-actions
Copy link
Contributor

github-actions bot commented Feb 27, 2026

📋 Code Owners Summary

2 file(s) changed, 2 with assigned owners

2 team(s) affected: @brave/sec-team, @brave/sync-reviewers


Owners and Their Files

@brave/sec-team — 1 file(s)

@brave/sync-reviewers — 1 file(s)

@brave-builds
Copy link
Collaborator

Warning

You have got a presubmit warning. Please address it if possible.

Expected one of license headers in existing files:
// Copyright (c) <year> The Brave Authors. All rights reserved.
// This Source Code Form is subject to the terms of the Mozilla Public
// License, v. 2.0. If a copy of the MPL was not distributed with this file,
// You can obtain one at https://mozilla.org/MPL/2.0/.

/* Copyright (c) <year> The Brave Authors. All rights reserved.
 * This Source Code Form is subject to the terms of the Mozilla Public
 * License, v. 2.0. If a copy of the MPL was not distributed with this file,
 * You can obtain one at https://mozilla.org/MPL/2.0/. */

# Copyright (c) <year> The Brave Authors. All rights reserved.
# This Source Code Form is subject to the terms of the Mozilla Public
# License, v. 2.0. If a copy of the MPL was not distributed with this file,
# You can obtain one at https://mozilla.org/MPL/2.0/.

<!-- Copyright (c) <year> The Brave Authors. All rights reserved.
     This Source Code Form is subject to the terms of the Mozilla Public
     License, v. 2.0. If a copy of the MPL was not distributed with this file,
     You can obtain one at https://mozilla.org/MPL/2.0/. -->

Items:

components/brave_sync/crypto/crypto.cc

@diracdeltas diracdeltas enabled auto-merge (squash) February 28, 2026 04:12
Copy link
Contributor

@AlexeyBarabash AlexeyBarabash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@diracdeltas diracdeltas merged commit b240e24 into master Feb 28, 2026
22 checks passed
@diracdeltas diracdeltas deleted the fix/hkdf branch February 28, 2026 13:58
@github-actions github-actions bot added this to the 1.89.x - Nightly milestone Feb 28, 2026
@brave-builds
Copy link
Collaborator

Released in v1.89.89

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HKDF return value only checked via DCHECK, not in release builds

7 participants