Disable Chromium test AutoPictureInPictureTabHelperBrowserTest.OverlaySettingViewIsShownForDocumentPip#34337
Merged
bbondy merged 1 commit intobrave:masterfrom Feb 28, 2026
Conversation
…ySettingViewIsShownForDocumentPip This is an upstream Chromium test that crashes with a null pointer dereference in ASAN builds. The root cause is a race condition where ShowBubble() is deferred via PostTask in AddedToWidget(), so auto_pip_setting_view_ may still be null when the test accesses it. Upstream flake rate: 4.7% overall, 12-13% recently (LUCI Analysis). Already disabled on Linux upstream since Nov 2023 (crbug.com/1500939). Brave does not modify the PIP code paths involved. Resolves brave/brave-browser#53185
bbondy
approved these changes
Feb 28, 2026
Collaborator
|
Released in v1.89.89 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Disable flaky upstream Chromium test
AutoPictureInPictureTabHelperBrowserTest.OverlaySettingViewIsShownForDocumentPipwhich crashes with a null pointer dereference on Windows ASAN builds.Note: This is a Chromium test (located in
./src/chrome/browser/picture_in_picture/, not./src/brave/).Root Cause
The test crashes in
AutoPipSettingView::OnButtonPressed(auto_pip_setting_view.cc:211) due to a null pointer dereference. The root cause is a race condition whereShowBubble()is deferred viaPostTaskinAddedToWidget(), soauto_pip_setting_view_may still be null when the test accesses it.Fix
Added the test to
test/filters/browser_tests.filterto disable it. This is consistent with the sibling testOverlaySettingViewIsShownForVideoPipwhich is already disabled in the same filter file.Test Plan
Resolves brave/brave-browser#53185