Disable flaky AutoPictureInPictureTabHelperBrowserTest.PromptResultRecorded_VideoConferencingAllowOnce#34338
Merged
bbondy merged 2 commits intobrave:masterfrom Feb 28, 2026
Conversation
…corded_VideoConferencingAllowOnce This Chromium test has a 10.9% upstream flake rate (111,249 verdicts in LUCI Analysis). The crash is in upstream code (AutoPipSettingView:: OnButtonPressed) due to a race condition between PostTask-deferred ShowBubble() and the test accessing the view before the posted task runs. No Brave modifications exist for this code path. Resolves brave/brave-browser#53186
bbondy
approved these changes
Feb 28, 2026
Collaborator
|
Released in v1.89.89 |
bbondy
added a commit
that referenced
this pull request
Mar 2, 2026
…corded_VideoConferencingAllowOnce (#34338) This Chromium test has a 10.9% upstream flake rate (111,249 verdicts in LUCI Analysis). The crash is in upstream code (AutoPipSettingView:: OnButtonPressed) due to a race condition between PostTask-deferred ShowBubble() and the test accessing the view before the posted task runs. No Brave modifications exist for this code path. Resolves brave/brave-browser#53186 Co-authored-by: Brian R. Bondy <netzen@gmail.com>
7 tasks
bbondy
added a commit
that referenced
this pull request
Mar 2, 2026
…corded_VideoConferencingAllowOnce (#34338) This Chromium test has a 10.9% upstream flake rate (111,249 verdicts in LUCI Analysis). The crash is in upstream code (AutoPipSettingView:: OnButtonPressed) due to a race condition between PostTask-deferred ShowBubble() and the test accessing the view before the posted task runs. No Brave modifications exist for this code path. Resolves brave/brave-browser#53186 Co-authored-by: Brian R. Bondy <netzen@gmail.com>
7 tasks
bbondy
added a commit
that referenced
this pull request
Mar 2, 2026
…corded_VideoConferencingAllowOnce (#34338) This Chromium test has a 10.9% upstream flake rate (111,249 verdicts in LUCI Analysis). The crash is in upstream code (AutoPipSettingView:: OnButtonPressed) due to a race condition between PostTask-deferred ShowBubble() and the test accessing the view before the posted task runs. No Brave modifications exist for this code path. Resolves brave/brave-browser#53186 Co-authored-by: Brian R. Bondy <netzen@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Disables flaky Chromium test
AutoPictureInPictureTabHelperBrowserTest.PromptResultRecorded_VideoConferencingAllowOncein browser_tests.filter.Note: This is a Chromium test (located in
./src/chrome/browser/picture_in_picture/, not./src/brave/).Root Cause
ASAN crash at
AutoPipSettingView::OnButtonPressed(access-violation at near-null address 0x468). The crash is caused by a race condition betweenPostTask-deferredShowBubble()call and the test immediately accessingget_view_for_testing()before the posted task runs. Under ASAN (slower execution on Windows), thePostTaskhasn't completed when the test accesses the view, resulting in a nullptr dereference.Fix
Added the test to
test/filters/browser_tests.filterto disable it, since this is a purely upstream Chromium issue with a high flake rate and no Brave code involvement.Test Plan
Resolves brave/brave-browser#53186