Fixed SameSite cookies exposed due cross-site navigations.#34352
Open
Fixed SameSite cookies exposed due cross-site navigations.#34352
Conversation
Contributor
📋 Code Owners Summary3 file(s) changed, 3 with assigned owners 2 team(s) affected: Owners and Their Files
|
diracdeltas
approved these changes
Mar 2, 2026
netzenbot
approved these changes
Mar 2, 2026
darkdh
reviewed
Mar 2, 2026
| https_server_->RegisterRequestHandler( | ||
| base::BindRepeating(&HandleSetStrictCookie)); | ||
| net::test_server::RegisterDefaultHandlers(https_server_.get()); | ||
| https_server_->SetSSLConfig(net::EmbeddedTestServer::CERT_TEST_NAMES); |
Member
There was a problem hiding this comment.
this is redundant as we already called it in https://github.com/brave/brave-core/pull/34352/changes#diff-dc66b41ce5d1e1f3f99aee00a6f11fb5b1d37e89082f614c1f5bcd01765e9edfR51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.