Update to sidebar header styles for upcoming wallet as sidepanel#34354
Open
Update to sidebar header styles for upcoming wallet as sidepanel#34354
Conversation
effort to standadrize panels in desktop so the future wallet as a sidebar item can work correctly https://www.figma.com/design/Fbtxfv2ATGlfH7nPXiWAbR/%F0%9F%92%BB-Browser-Sidebar?node-id=1749-34459
github-actions
bot
added
the
CI/storybook-url
aguscruiz
requested review from
fallaciousreasoning,
petemill,
sangwoo108 and
simonhong
and removed request for
petemill
Collaborator
|
A Storybook has been deployed to preview UI for the latest push |
Bonus, but it's very badly needed to have a properly responsive panel
Contributor
📋 Code Owners Summary14 file(s) changed, 4 with assigned owners 1 team(s) affected: Owners and Their Files
|
aguscruiz
changed the title
netzenbot
approved these changes
Mar 2, 2026
| mixer[kColorSidebarPanelHeaderSeparator] = {nala::kColorDividerSubtle}; | ||
| mixer[kColorSearchConversionCloseButton] = {nala::kColorIconDefault}; | ||
| mixer[kColorSidebarPanelHeaderBackground] = {nala::kColorContainerBackground}; | ||
| mixer[kColorSidebarPanelHeaderBackground] = {nala::kColorPageBackground}; |
Contributor
There was a problem hiding this comment.
any reason we can't just use the Nala color directly, rather than via this one?
| mixer[kColorSidebarPanelHeaderTitle] = {nala::kColorTextPrimary}; | ||
| mixer[kColorSidebarPanelHeaderButton] = {nala::kColorIconDefault}; | ||
| mixer[kColorSidebarPanelHeaderButtonHovered] = {nala::kColorNeutral60}; | ||
| mixer[kColorSidebarPanelBackground] = {nala::kColorContainerBackground}; |
Contributor
There was a problem hiding this comment.
could we just use this nala token directly?
|
|
||
| mixer[kColorSidebarPanelHeaderSeparator] = {nala::kColorPrimitiveNeutral20}; | ||
| mixer[kColorSidebarPanelHeaderBackground] = {nala::kColorPrimitiveNeutral5}; | ||
| mixer[kColorSidebarPanelHeaderBackground] = {nala::kColorPageBackground}; |
Comment on lines
+56
to
+60
| .sp-card { | ||
| max-width: none; | ||
| } | ||
|
|
||
| customize-chrome-appearance, |
Contributor
There was a problem hiding this comment.
could these selectors be joined with a ,
| @@ -22,9 +22,7 @@ | |||
| <link rel="manifest" href="manifest.webmanifest"> | |||
| <style> | |||
| @media (prefers-color-scheme: dark) { | |||
Contributor
There was a problem hiding this comment.
can this be removed now?
Contributor
There was a problem hiding this comment.
ah wait, I think this is needed to avoid a FOUC while we're loading the page
Collaborator
Author
There was a problem hiding this comment.
I tried loading and reloading a number of times and didn't get the flashing white background when in dark mode. Do you want me to keep it anyways?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Effort to standadrize panels in desktop so the future wallet as a sidebar item can work within a system
https://www.figma.com/design/Fbtxfv2ATGlfH7nPXiWAbR/%F0%9F%92%BB-Browser-Sidebar?node-id=1749-34459
Resolves brave/brave-browser#53164
Resolves brave/brave-browser#53165
Resolves brave/brave-browser#47881
Current version
Updated version
Default theme - light
Default theme - dark
Color theme - light
Color theme - dark
Update to Theme and Toolbar sidepanels to make them responsive
Current version
Updated version
Screen.Recording.2026-03-02.at.12.06.25.mov