Refactor WAL appends to async background writer with batching and backpressure#12
Merged
bravo1goingdark merged 1 commit intomainfrom Feb 3, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
innermutex by offloading file I/O to a dedicated background writer task and enable batching for higher throughput.Description
WalInner/innermutex model with a boundedtokio::mpscchannel and aWalWriterbackground task that owns the file and performs batched writes and fsyncs according toWalConfig.AtomicU64(next_id) soappendreturns the assigned id immediately andappendenqueues aWalWriteRequestviatry_send, returning aWalError::BackpressureorWalError::WriterStoppedon overload/stop.Arc<Mutex<HashMap<u64, u64>>>and update it from the writer after each batch;flushis implemented by sending aWalMessage::Flushwith aoneshotresponder to the writer.append_countandbytes_writtento atomics updated by the writer, addedchannel_capacitytoWalConfig, and added error variantsBackpressure,WriterStopped, andInvalidConfig.Testing
wal::testsbut were not run as part of this rollout).