Refactor subscriber queues to bounded tokio mpsc channels with batching and separate QoS1 inflight tracking#13
Closed
bravo1goingdark wants to merge 1 commit intomainfrom
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Mutex<VecDeque>and into a bounded channel implementation.Description
SubscriberQueueinternalMutex<VecDeque<...>>with a boundedtokio::mpscchannel and addedenqueue_batch/send_entryhelpers to support batching and different backpressure policies via a newBackpressurePolicyenum andBrokerConfig::per_subscriber_backpressure.SubscriberInflight(aMutex<HashMap<DeliveryTag, QueueEntry>>) and changeddequeue/ack/maintenance logic to use this separate inflight map.Broker::publish_with_wal_idby collecting subscriber references and callingenqueue_batchto reduce per-message locking and cloning overhead.QueueEntry::newconstructor and helper methods:SubscriberQueue::requeue,SubscriberInflight::maintenance_tick,SubscriberInflight::insert/ack/lenand updatedmaintenance_tickto use the new inflight-based retry/requeue flow.bench/src/main.rs,blipmqd/src/main.rs,tests/daemon_integration.rs, andtests/chaos_recovery.rs.Testing
cargo fmtto format modified files; formatting succeeded.cargo test) were executed as part of this change.Codex Task