Add streaming WAL replay with scheduler yields#16
Closed
bravo1goingdark wants to merge 1 commit intomainfrom
Closed
Add streaming WAL replay with scheduler yields#16bravo1goingdark wants to merge 1 commit intomainfrom
bravo1goingdark wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Vec, enabling lower memory usage and backpressure-friendly recovery.iterate_frombehavior for tests and callers by implementing it on top of the new streaming API.Description
WriteAheadLog::iterate_from_streammethod that takes a callback(WalRecord) -> Future<Output=Result<(), E>>and streams records from the WAL starting at a given id, mapping WAL I/O errors into the callback error type viaE: From<WalError>and allowing incremental processing.iterate_fromimplementation throughiterate_from_streamso the old vector-based API remains available for tests and callers.Broker::replay_from_walto useiterate_from_streamand process records one-by-one, callingtokio::task::yield_now().awaiteveryyield_everyrecords (set to1024) to yield to the scheduler and avoid long monopolization of the runtime.WalRecordimport fromcore::lib.rsas the broker now decodes records inside the streaming callback.Testing
iterate_frombehavior is preserved because it delegates to the new streaming API.