Add missing test coverage for Dalli::Server#30
Merged
mattwd7 merged 1 commit intobraze-mainfrom Feb 19, 2026
Merged
Conversation
Cover initialization defaults, hostname parsing (TCP, UNIX, IPv4, IPv6, FQDN), serialize/deserialize with compression flags, close, alive?, verify_state, failure!/down!/up!, multi state, split, TTL translation, guard_max_value, and auth credential resolution. Co-authored-by: Cursor <cursoragent@cursor.com>
pcalcado
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Substantially expands test coverage for
Dalli::Server:close: no-op when nil, socket teardown and state resetalive?: sock-present, down_retry_delay period, reconnect after delaymulti_response_completed?/multi_response_abort: buffer state managementTimeout::Errorcloses socket,MarshalErrorreturns falseserialize: Marshal flags, raw mode, compression thresholds (min/max/per-request), combined flags,MarshalErrorwrappingdeserialize: raw, compressed, combined flags,UnmarshalErrorfor bad data, custom serializer error handlingverify_state: inprogress check, fork detectionfailure!/down!/up!: failure counting, server down lifecyclemulti?: thread-local statesplit: 64-bit integer splittingneed_auth?/username/password: option and env variable resolutionguard_max_value: under-max yield, over-max warning, error modeMade with Cursor