Skip to content

Add test coverage for Dalli::Threadsafe#32

Merged
mattwd7 merged 1 commit intobraze-mainfrom
NOTIX-add-tests-test_threadsafe
Feb 19, 2026
Merged

Add test coverage for Dalli::Threadsafe#32
mattwd7 merged 1 commit intobraze-mainfrom
NOTIX-add-tests-test_threadsafe

Conversation

@mattwd7
Copy link

@mattwd7 mattwd7 commented Feb 19, 2026

Summary

Adds unit tests for Dalli::Threadsafe:

  • Monitor initialization when extended onto a server
  • lock! / unlock!: acquires and releases the monitor
  • alive? and close are wrapped in synchronize
  • Without the extension: lock! / unlock! are no-ops

Made with Cursor

Cover Monitor initialization, lock!/unlock! lifecycle,
synchronization of alive? and close, and no-op behavior
without the Threadsafe extension.

Co-authored-by: Cursor <cursoragent@cursor.com>
Copy link
Author

@mattwd7 mattwd7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 👍

@mattwd7 mattwd7 marked this pull request as ready for review February 19, 2026 20:20
@mattwd7 mattwd7 requested a review from a team as a code owner February 19, 2026 20:20
@mattwd7 mattwd7 merged commit d31b075 into braze-main Feb 19, 2026
2 checks passed
@mattwd7 mattwd7 deleted the NOTIX-add-tests-test_threadsafe branch February 19, 2026 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants